Change broadcast detection to support the event's recipient list #135

Open
opened 2023-03-12 20:30:36 +00:00 by NorbiPeti · 0 comments
NorbiPeti commented 2023-03-12 20:30:36 +00:00 (Migrated from github.com)

The current implementation doesn't check what the recipients of the message are, it just assumes that everyone can see the broadcasted message. This may cause a privacy issue depending on what other plugins do.

  • Remove all senders from the list that are created because someone talked in the chat (regardless of account connection status)
  • Only send it in the public chat if the fake public user has access to it
  • Figure out a similar solution for the custom chats too, I guess
  • Might involve reworking the different player types (and differentiate from DiscordPlayer)
The current implementation doesn't check what the recipients of the message are, it just assumes that everyone can see the broadcasted message. This may cause a privacy issue depending on what other plugins do. * Remove all senders from the list that are created because someone talked in the chat (regardless of account connection status) * Only send it in the public chat if the fake public user has access to it * Figure out a similar solution for the custom chats too, I guess * Might involve reworking the different player types (and differentiate from DiscordPlayer)
Sign in to join this conversation.
No description provided.