Towny Withdraw Perms not honoured #36

New issue

Closed

opened 2018-08-10 19:26:56 +00:00 by Gryph667 · 1 comment

Gryph667 commented

2018-08-10 19:26:56 +00:00

(Migrated from github.com)

Describe the bug
Town and nation members are allowed to /t withdraw XXX and /n withdraw despite not having the permissions for those commands. Towns and nations have to be able to set rents and taxes that aren't immediately refunded without the group leader's knowledge.

To Reproduce
Steps to reproduce the behavior:

Confirm in TownyPermissions file that only mayors have
towny.command.town.* which includes the Withdraw command
Confirm in TownyPermissions file that only kings have
towny.command.nation.* which includes the withdraw command
Confirm there is no reference to "towny.command.town.withdraw" or "towny.command.nation.withdraw" anywhere in the same file that would explicitly grant the permission
Log into a non king/non mayor that is a member of a town and/or nation
Execute the /t withdraw 2 and/or /n withdraw 2 commands

Expected behavior
Person should get an error saying they aren't allowed to grab the cash

Actual Results
User gets the cash they are supposed to be blocked from accessing.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

**Describe the bug** Town and nation members are allowed to /t withdraw XXX and /n withdraw despite not having the permissions for those commands. Towns and nations have to be able to set rents and taxes that aren't immediately refunded without the group leader's knowledge. **To Reproduce** Steps to reproduce the behavior: 1. Confirm in TownyPermissions file that only mayors have towny.command.town.* which includes the Withdraw command 2. Confirm in TownyPermissions file that only kings have towny.command.nation.* which includes the withdraw command 3. Confirm there is no reference to "towny.command.town.withdraw" or "towny.command.nation.withdraw" anywhere in the same file that would explicitly grant the permission 4. Log into a non king/non mayor that is a member of a town and/or nation 5. Execute the /t withdraw 2 and/or /n withdraw 2 commands **Expected behavior** Person should get an error saying they aren't allowed to grab the cash **Actual Results** User gets the cash they are supposed to be blocked from accessing. **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here.

NorbiPeti commented

2018-09-08 22:29:11 +00:00

(Migrated from github.com)

Fixed in #38 and fixed again in d40e40b.

Fixed in #38 and fixed again in d40e40b.