From 5650dada42004ef2d934f4abf4d186d7ec895808 Mon Sep 17 00:00:00 2001 From: NorbiPeti Date: Wed, 27 Jan 2021 23:57:51 +0100 Subject: [PATCH] Update rules and add pass min length validator --- firestore.rules | 15 ++++++++++----- src/app/register/register.component.ts | 3 ++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/firestore.rules b/firestore.rules index e994b4b..ee941a1 100644 --- a/firestore.rules +++ b/firestore.rules @@ -4,21 +4,26 @@ service cloud.firestore { function sameUser(user) { return request.auth != null && request.auth.uid == user; } - function getUserData() { + /*function getUserData() { return get(/databases/$(database)/documents/users/$(request.auth.uid)).data; - } + }*/ + //Felhasználói adatok kezelése match /users/{user} { allow create: if sameUser(user) && request.auth.uid == request.resource.data.author_uid; allow get, list, update, delete: if sameUser(user) && request.auth.uid == resource.data.author_uid; } + //Adminoknak mindent lehet match /data/{document=**} { - allow get, list, create, update, delete: if getUserData().isAdmin == true; + allow get, list, create, update, delete: if auth.token.admin; } - //Diákok megnézhetik a kurzus adatait - match /data/courses/{course} { + //Diákok megnézhetik a tárgy adatait + match /data/subjects/{subject=**} { allow get, list: if request.auth.uid in resource.data.students; } + match /data/subjects/{subject}/requirements/{requirement=**} { + allow read, write: if request.auth.uid in resource.data.teachers; + } } } diff --git a/src/app/register/register.component.ts b/src/app/register/register.component.ts index 209323b..e5752e5 100644 --- a/src/app/register/register.component.ts +++ b/src/app/register/register.component.ts @@ -29,7 +29,8 @@ export class RegisterComponent implements OnInit { ]); passFormControl = new FormControl('', [ - Validators.required + Validators.required, + Validators.minLength(8) ]); matcher = new FormErrorStateMatcher();