ChromaGaming/Chroma-Chat
1
0
Fork 0
Code Issues 15 Pull requests 1 Projects Releases 8 Packages Wiki Activity

Fixed NPE when getting flairs #54

Closed
alisolarflare wants to merge 1 commit from Bugfix into master
pull from: Bugfix
merge into: ChromaGaming:master
Conversation 4 Commits 1 Files changed 1 +1 -1
alisolarflare commented 2016-12-17 06:53:54 +00:00 (Migrated from github.com)
Copy link

Side effect: reduced Legendosh bug to happen every 10 seconds. I suspect
the author variable is null

Side effect: reduced Legendosh bug to happen every 10 seconds. I suspect the author variable is null
NorbiPeti commented 2016-12-17 10:29:52 +00:00 (Migrated from github.com)
Copy link

You're 7 commits behind though... 😛 I'm fairly sure I fixed this yesterday.

You're 7 commits behind though... 😛 I'm fairly sure I fixed this yesterday.
NorbiPeti commented 2016-12-18 10:50:46 +00:00 (Migrated from github.com)
Copy link

Please check if the latest version errors for you.

Please check if the latest version errors for you.
alisolarflare commented 2016-12-19 04:40:50 +00:00 (Migrated from github.com)
Copy link

No, the master branch still errors like hell for me, check the post on #bot-room

No, the master branch still errors like hell for me, check the post on #bot-room
NorbiPeti commented 2016-12-19 11:04:21 +00:00 (Migrated from github.com)
Copy link

It looks like getFlairState errors now... I can fix that later today.

The reason I don't really want to accept this PR because these aren't supposed to be null at all.

It looks like getFlairState errors now... I can fix that later today. The reason I don't really want to accept this PR because these aren't *supposed* to be null at all.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
dependencies

Pull requests that update a dependency file

  
duplicate

   
enhancement

   
error handling

   
feature

   
formatting

   
fun

   
help wanted

   
invalid

   
needs testing

   
question

   
wontfix
No labels
bug
dependencies
duplicate
enhancement
error handling
feature
formatting
fun
help wanted
invalid
needs testing
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ChromaGaming/Chroma-Chat#54
No description provided.
Delete branch "Bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?