Update to 1.17

CrashCringle12 commented

2021-07-02 23:05:01 +00:00

(Migrated from github.com)

I spent a few hours attempting to update the plugin to work on 1.17.

From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors.

One thing I couldn't figure out was how to convert this line

var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());

This is what i had in there just to remove the error, merely just a placeholder

RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);

Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning.

I spent a few hours attempting to update the plugin to work on 1.17. From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors. One thing I couldn't figure out was how to convert this line `var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());` This is what i had in there just to remove the error, merely just a placeholder `RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);` Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning.

NorbiPeti commented

2021-07-09 00:38:26 +00:00

(Migrated from github.com)

Thanks for the PR! However, it seems like custom dimensions are already being loaded by the server on 1.17(.1) Spigot without the plugin, was that not the case when you were testing it?

DecisiveDolphin commented

2022-01-11 03:50:31 +00:00

(Migrated from github.com)

I spent a few hours attempting to update the plugin to work on 1.17.

From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors.

One thing I couldn't figure out was how to convert this line

var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());

This is what i had in there just to remove the error, merely just a placeholder

RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);

Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning.

Howdy folks,

Sorry to disrupt this convo a bit; were you at least semi-successful in doing this CrashCringle? I've tried decompiling the jar to check it out myself, but it's beyond me as a learning Java student. Almost motivated to keep learning quite literally just to try and "crack" this jar file & update it to 1.17.1. (PaperMC).

Hopefully you're still alive out there, and hopefully if you're willing, you could teach me the route you took to do this!

P.S. If possible, PLEASE send me the 1.17(.1) jar!

> I spent a few hours attempting to update the plugin to work on 1.17. > > From my trials it works for my purposes and was able to load custom dimensions but there are still a few errors. > > One thing I couldn't figure out was how to convert this line > > `var dimRegistry = ((RegistryMaterials<DimensionManager>) console.customRegistry.a());` > > This is what i had in there just to remove the error, merely just a placeholder > > `RegistryMaterials<DimensionManager> dimRegistry = new RegistryMaterials<DimensionManager>(null, null);` > > Uh I realize I changed the pom.xml and added another file, really that's just to show what i was working with and what was done on my end to have it functioning. Howdy folks, Sorry to disrupt this convo a bit; were you at least semi-successful in doing this CrashCringle? I've tried decompiling the jar to check it out myself, but it's beyond me as a learning Java student. Almost motivated to keep learning quite literally just to try and "crack" this jar file & update it to 1.17.1. (PaperMC). Hopefully you're still alive out there, and hopefully if you're willing, you could teach me the route you took to do this! P.S. If possible, PLEASE send me the 1.17(.1) jar!

NorbiPeti commented

2022-01-11 09:38:11 +00:00

(Migrated from github.com)

Hey @DecisiveDolphin! Spigot 1.17 (and its forks) should have custom dimension support. Have you tried adding the datapack in your main world and seeing if it works? I wanted to update the plugin but then focused on other things once I realized it's not necessary. However, I have been thinking on a version that updates existing dimensions to the vanilla stuff (which is just moving the dimension data around).

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin CrashCringle12/master:CrashCringle12/master

git checkout CrashCringle12/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff CrashCringle12/master

git checkout CrashCringle12/master

git rebase master

git checkout master

git merge --ff-only CrashCringle12/master

git checkout CrashCringle12/master

git rebase master

git checkout master

git merge --no-ff CrashCringle12/master

git checkout master

git merge --squash CrashCringle12/master

git checkout master

git merge --ff-only CrashCringle12/master

git checkout master

git merge CrashCringle12/master

git push origin master

Update to 1.17 #11

Checkout

Merge