Add text block support to RC importer & general tweaks to make that work

Pixi/Audio/AudioFakeImporter.cs

@@ -1,37 +0,0 @@
-using System;
-using GamecraftModdingAPI;
-using GamecraftModdingAPI.Utility;
-using Pixi.Common;
-
-namespace Pixi.Audio
-{
-    public class AudioFakeImporter : Importer
-    {
-        public int Priority { get; } = 0;
-        public bool Optimisable { get; } = false;
-        public string Name { get; } = "AudioWarning~Spell";
-        public BlueprintProvider BlueprintProvider { get; } = null;
-        public bool Qualifies(string name)
-        {
-            return name.EndsWith(".flac", StringComparison.InvariantCultureIgnoreCase)
-                || name.EndsWith(".ogg", StringComparison.InvariantCultureIgnoreCase)
-                || name.EndsWith(".mp3", StringComparison.InvariantCultureIgnoreCase)
-                || name.EndsWith(".wav", StringComparison.InvariantCultureIgnoreCase)
-                || name.EndsWith(".aac", StringComparison.InvariantCultureIgnoreCase);
-        }
-
-        public BlockJsonInfo[] Import(string name)
-        {
-            Logging.CommandLogWarning($"Audio importing only works with MIDI (.mid) files, which '{name}' is not.\nThere are many converters online, but for best quality use a MIDI file made from a music transcription.\nFor example, musescore.com has lots of good transcriptions and they offer a 30-day free trial.");
-            return null;
-        }
-
-        public void PreProcess(string name, ref ProcessedVoxelObjectNotation[] blocks)
-        {
-        }
-
-        public void PostProcess(string name, ref Block[] blocks)
-        {
-        }
-    }
-}

Pixi/Audio/MidiImporter.cs

@@ -31,8 +31,6 @@ namespace Pixi.Audio
 
         public static byte Key = 0;
 
-        public static float VolumeMultiplier = 1f;
-
         public MidiImporter()
         {
             AudioTools.GenerateProgramMap();
@@ -51,6 +49,10 @@ namespace Pixi.Audio
             Logging.MetaLog($"Found {midi.GetNotes().Count()} notes over {midi.GetDuration<MidiTimeSpan>().TimeSpan} time units");
             BlockJsonInfo[] blocks = new BlockJsonInfo[(midi.GetNotes().Count() * 2) + 3];
             List<BlockJsonInfo> blocksToBuild = new List<BlockJsonInfo>();
+#if DEBUG
+            // test (for faster, but incomplete, imports)
+            if (blocks.Length > 103) blocks = new BlockJsonInfo[103];
+#endif
             // convert Midi notes to sfx blocks
             Dictionary<long, uint> breadthCache = new Dictionary<long, uint>();
             Dictionary<long, uint> depthCache = new Dictionary<long, uint>();
@@ -192,7 +194,7 @@ namespace Pixi.Audio
                 sfx.Pitch = n.NoteNumber - 60 + Key; // In MIDI, 60 is middle C, but GC uses 0 for middle C
                 sfx.TrackIndex = channelPrograms[n.Channel];
                 sfx.Is3D = ThreeDee;
-                sfx.Volume = AudioTools.VelocityToVolume(n.Velocity) * VolumeMultiplier;
+                sfx.Volume = AudioTools.VelocityToVolume(n.Velocity);
                 count++;
                 // connect wires
                 if (t == null) continue; // this should never happen

Pixi/Common/BlueprintUtility.cs

@@ -14,18 +14,11 @@ namespace Pixi.Common
             StreamReader bluemap = new StreamReader(File.OpenRead(name));
             return JsonConvert.DeserializeObject<Dictionary<string, BlockJsonInfo[]>>(bluemap.ReadToEnd());
         }
-
+        
         public static Dictionary<string, BlockJsonInfo[]> ParseBlueprintResource(string name)
         {
-            StreamReader bluemap;
-#if DEBUG
-            if (File.Exists(name))
-                bluemap = File.OpenText(name);
-            else
-#endif
-                bluemap = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream(name));
-            using (bluemap)
-                return JsonConvert.DeserializeObject<Dictionary<string, BlockJsonInfo[]>>(bluemap.ReadToEnd());
+            StreamReader bluemap = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream(name));
+            return JsonConvert.DeserializeObject<Dictionary<string, BlockJsonInfo[]>>(bluemap.ReadToEnd());
         }
 
         public static ProcessedVoxelObjectNotation[][] ProcessAndExpandBlocks(string name, BlockJsonInfo[] blocks, BlueprintProvider blueprints)

Pixi/Common/ColorSpaceUtility.cs

@@ -314,7 +314,6 @@ namespace Pixi.Common
 							count++;
 						}
 					}
-					yield return asyncHandle.Continue();
 		        }
 	        }
         }

Pixi/Common/CommandRoot.cs

@@ -157,7 +157,7 @@ namespace Pixi.Common
 #endif
             // import blocks
             BlockJsonInfo[] blocksInfo = magicImporter.Import(name);
-            if (blocksInfo == null || blocksInfo.Length == 0)
+            if (blocksInfo.Length == 0)
             {
 #if DEBUG
                 Logging.CommandLogError($"Importer {magicImporter.Name} didn't provide any blocks to import. Mission Aborted!");
@@ -564,58 +564,6 @@ namespace Pixi.Common
                             }
                         }
                         break;
-                    case BlockIDs.DampedSpring:
-                        string[] springSplit = pVONs[i].metadata.Split('\t');
-                        if (springSplit.Length > 1 && float.TryParse(springSplit[1], out float stiffness))
-                        {
-                            DampedSpring d = blocks[i].Specialise<DampedSpring>();
-                            d.Stiffness = stiffness;
-                            if (springSplit.Length > 2 && float.TryParse(springSplit[2], out float damping))
-                            {
-                                d.Damping = damping;
-                            }
-                        }
-                        break;
-                    case BlockIDs.ServoAxle:
-                    case BlockIDs.ServoHinge:
-                    case BlockIDs.PneumaticAxle:
-                    case BlockIDs.PneumaticHinge:
-                        string[] servoSplit = pVONs[i].metadata.Split('\t');
-                        if (servoSplit.Length > 1 && float.TryParse(servoSplit[1], out float minAngle))
-                        {
-                            Servo s = blocks[i].Specialise<Servo>();
-                            s.MinimumAngle = minAngle;
-                            if (servoSplit.Length > 2 && float.TryParse(servoSplit[2], out float maxAngle))
-                            {
-                                s.MaximumAngle = maxAngle;
-                                if (servoSplit.Length > 3 && float.TryParse(servoSplit[3], out float maxForce))
-                                {
-                                    s.MaximumForce = maxForce;
-                                    if (servoSplit.Length > 4 && bool.TryParse(servoSplit[4], out bool reverse))
-                                    {
-                                        s.Reverse = reverse;
-                                    }
-                                }
-                            }
-                        }
-                        break;
-                    case BlockIDs.MotorM:
-                    case BlockIDs.MotorS:
-                        string[] motorSplit = pVONs[i].metadata.Split('\t');
-                        if (motorSplit.Length > 1 && float.TryParse(motorSplit[1], out float topSpeed))
-                        {
-                            Motor m = blocks[i].Specialise<Motor>();
-                            m.TopSpeed = topSpeed;
-                            if (motorSplit.Length > 2 && float.TryParse(motorSplit[2], out float torque))
-                            {
-                                m.Torque = torque;
-                                if (motorSplit.Length > 3 && bool.TryParse(motorSplit[3], out bool reverse))
-                                {
-                                    m.Reverse = reverse;
-                                }
-                            }
-                        }
-                        break;
                     default: break; // do nothing
                 }
             }

Pixi/Common/VoxelObjectNotationUtility.cs

@@ -42,7 +42,7 @@ namespace Pixi.Common
 		public static BlockJsonInfo JsonObject(Block block, float[] origin = null)
 		{
 			if (origin == null) origin = origin_base;
-			BlockJsonInfo jsonInfo = new BlockJsonInfo
+			return new BlockJsonInfo
 			{
 				name = block.Type.ToString(),
 				position = new float[3] { block.Position.x - origin[0], block.Position.y - origin[1], block.Position.z - origin[2]},
@@ -50,37 +50,6 @@ namespace Pixi.Common
 				color = ColorSpaceUtility.UnquantizeToArray(block.Color),
 				scale = new float[3] {block.Scale.x, block.Scale.y, block.Scale.z},
 			};
-			// custom stats for special blocks
-			switch (block.Type)
-			{
-				case BlockIDs.TextBlock:
-					TextBlock t = block.Specialise<TextBlock>();
-					jsonInfo.name += "\t" + t.Text + "\t" + t.TextBlockId;
-					break;
-				case BlockIDs.ConsoleBlock:
-					ConsoleBlock c = block.Specialise<ConsoleBlock>();
-					jsonInfo.name += "\t" + c.Command + "\t" + c.Arg1 + "\t" + c.Arg2 + "\t" + c.Arg3;
-					break;
-				case BlockIDs.DampedSpring:
-					DampedSpring d = block.Specialise<DampedSpring>();
-					jsonInfo.name += "\t" + d.Stiffness + "\t" + d.Damping;
-					break;
-				case BlockIDs.ServoAxle:
-				case BlockIDs.ServoHinge:
-				case BlockIDs.PneumaticAxle:
-				case BlockIDs.PneumaticHinge:
-					Servo s = block.Specialise<Servo>();
-					jsonInfo.name += "\t" + s.MinimumAngle + "\t" + s.MaximumAngle + "\t" + s.MaximumForce + "\t" +
-					                 s.Reverse;
-					break;
-				case BlockIDs.MotorM:
-				case BlockIDs.MotorS:
-					Motor m = block.Specialise<Motor>();
-					jsonInfo.name += "\t" + m.TopSpeed + "\t" + m.Torque + "\t" + m.Reverse;
-					break;
-				default: break;
-			}
-			return jsonInfo;
 		}
 
 		public static BlockIDs NameToEnum(BlockJsonInfo block)

Pixi/PixiPlugin.cs

@@ -47,19 +47,16 @@ namespace Pixi
 			root.Inject(new ImageTextBlockImporter());
 			root.Inject(new ImageCommandImporter());
 			// Robot functionality
-			var robot = new RobotInternetImporter();
-			root.Inject(robot);
+			root.Inject(new RobotInternetImporter());
 			//RobotCommands.CreateRobotCRFCommand();
 			//RobotCommands.CreateRobotFileCommand();
 #if DEBUG
 			// Development functionality
 			RobotCommands.CreatePartDumpCommand();
-			((RobotBlueprintProvider) robot.BlueprintProvider).AddDebugCommands();
 			root.Inject(new TestImporter());
 #endif
 			// Audio functionality
 			root.Inject(new MidiImporter());
-			root.Inject(new AudioFakeImporter());
 		}
 	}
 }

Pixi/Robots/CubeUtility.cs

@@ -215,10 +215,10 @@ namespace Pixi.Robots
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		private static void TranslateBlockId(uint cubeId, ref CubeInfo result)
 		{
-			if (map == null)
+            if (map == null)
 			{
 				StreamReader cubemap = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream("Pixi.cubes-id.json"));
-				map = JsonConvert.DeserializeObject<Dictionary<uint, string>>(cubemap.ReadToEnd());
+                map = JsonConvert.DeserializeObject<Dictionary<uint, string>>(cubemap.ReadToEnd());
 			}
 
 			if (!map.ContainsKey(cubeId))
@@ -231,34 +231,81 @@ namespace Pixi.Robots
 #endif
 			}
 			string cubeName = map[cubeId];
-
-			string gcName = cubeName.Contains("glass") || cubeName.Contains("windshield")
-				? "Glass"
-				: "Aluminium";
-			if (cubeName.Contains("round"))
-				gcName += "Rounded";
-
 			if (cubeName.Contains("cube"))
-				gcName += "Cube";
+			{
+				result.block = BlockIDs.AluminiumCube;
+                result.rotation = float3.zero;
+			}
 			else if (cubeName.Contains("prism") || cubeName.Contains("edge"))
-				gcName += "Slope";
+			{
+				if (cubeName.Contains("round"))
+				{
+					if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+                    {
+                        result.block = BlockIDs.GlassRoundedSlope;
+                    } else
+					    result.block = BlockIDs.AluminiumRoundedSlope;
+				}
+				else
+				{
+                    if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+                    {
+						result.block = BlockIDs.GlassSlope;
+                    } else
+					    result.block = BlockIDs.AluminiumSlope;
+				}
+			}
 			else if (cubeName.Contains("inner"))
-				gcName += "SlicedCube";
+            {
+                if (cubeName.Contains("round"))
+                {
+					if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+					{
+						result.block = BlockIDs.GlassRoundedSlicedCube;
+					} else
+					    result.block = BlockIDs.AluminiumRoundedSlicedCube;
+                }
+				else
+				{
+                    if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+                    {
+                        result.block = BlockIDs.GlassSlicedCube;
+                    } else
+					    result.block = BlockIDs.AluminiumSlicedCube;
+				}
+			}
 			else if (cubeName.Contains("tetra") || cubeName.Contains("corner"))
-				gcName += "Corner";
+            {
+                if (cubeName.Contains("round"))
+                {
+                    if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+                    {
+						result.block = BlockIDs.GlassRoundedCorner;
+                    } else
+                        result.block = BlockIDs.AluminiumRoundedCorner;
+                }
+				else
+				{
+                    if (cubeName.Contains("glass") || cubeName.Contains("windshield"))
+                    {
+                        result.block = BlockIDs.GlassCorner;
+                    } else
+					    result.block = BlockIDs.AluminiumCorner;
+				}
+			}
 			else if (cubeName.Contains("pyramid"))
-				gcName += "PyramidSegment";
+			{
+				result.block = BlockIDs.AluminiumPyramidSegment;
+			}
 			else if (cubeName.Contains("cone"))
-				gcName += "ConeSegment";
+			{
+				result.block = BlockIDs.AluminiumConeSegment;
+			}
 			else
 			{
 				result.block = BlockIDs.TextBlock;
 				result.name = cubeName;
-				return;
 			}
-
-			BlockIDs id = VoxelObjectNotationUtility.NameToEnum(gcName);
-			result.block = id;
 		}
 
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]

Pixi/Robots/RobotBlueprintProvider.cs

@@ -1,14 +1,12 @@
 using System;
 using System.Collections.Generic;
-using System.IO;
+
 using Svelto.DataStructures;
 using Unity.Mathematics;
 using UnityEngine;
 
 using GamecraftModdingAPI.Blocks;
-using GamecraftModdingAPI.Commands;
 using GamecraftModdingAPI.Utility;
-using Newtonsoft.Json;
 using Pixi.Common;
 
 namespace Pixi.Robots
@@ -35,8 +33,14 @@ namespace Pixi.Robots
 
             if (!botprints.ContainsKey(root.name) || RobotInternetImporter.CubeSize != 3)
             {
-	            BlockJsonInfo copy = root;
-                copy.name = $"TextBlock\t{root.name} ({CubeUtility.CubeIdDescription(uint.Parse(root.name))})\tPixi";
+                if (!parent.textBlockInfo.ContainsKey(name))
+                {
+                    parent.textBlockInfo[name] = new FasterList<string>();
+                }
+                BlockJsonInfo copy = root;
+                copy.name = "TextBlock";
+                Logging.MetaLog($"Parsing uint from '{root.name}'");
+                parent.textBlockInfo[name].Add(root.name + " (" + CubeUtility.CubeIdDescription(uint.Parse(root.name)) + ")");
                 return new BlockJsonInfo[1] {copy};
             }
             BlockJsonInfo[] blueprint = botprints[root.name];
@@ -92,49 +96,5 @@ namespace Pixi.Robots
 			}
             return adjustedBlueprint;
         }
-
-#if DEBUG
-        public void AddDebugCommands()
-        {
-	        CommandBuilder.Builder("PixiReload", "Reloads the robot blueprints")
-		        .Action(() => botprints = null).Build();
-	        CommandBuilder.Builder("RotateBlueprint",
-			        "Rotates a blueprint with a given ID and dumps the result to a file. 1 means 90 degrees.")
-		        .Action<string>(RotateBlueprint).Build();
-        }
-
-        private void RotateBlueprint(string parameters)
-        {
-	        var p = parameters.Split(' ');
-	        string id = p[0];
-	        var xyz = new int[3];
-	        for (int i = 0; i < xyz.Length; i++)
-		        xyz[i] = int.Parse(p[i + 1]) * 90;
-	        if (botprints == null)
-	        {
-		        botprints = BlueprintUtility.ParseBlueprintResource("Pixi.blueprints.json");
-	        }
-
-	        if (!botprints.ContainsKey(id))
-	        {
-		        Logging.CommandLogWarning("Blueprint with that ID not found.");
-		        return;
-	        }
-
-	        var bp = botprints[id];
-	        var rotChange = Quaternion.Euler(xyz[0], xyz[1], xyz[2]);
-	        for (var i = 0; i < bp.Length; i++)
-	        {
-		        ref var info =  ref bp[i];
-		        var pos = ConversionUtility.FloatArrayToFloat3(info.position);
-		        info.position = ConversionUtility.Float3ToFloatArray(rotChange * pos);
-		        var rot = Quaternion.Euler(ConversionUtility.FloatArrayToFloat3(info.rotation));
-		        info.rotation = ConversionUtility.Float3ToFloatArray((rotChange * rot).eulerAngles);
-	        }
-
-	        File.WriteAllText(id, JsonConvert.SerializeObject(bp));
-	        Logging.CommandLog("Blueprint rotated " + rotChange.eulerAngles + " and dumped");
-        }
-#endif
     }
 }

Pixi/Robots/RobotCommands.cs

@@ -31,9 +31,7 @@ namespace Pixi.Robots
 		{
 			Player local = new Player(PlayerType.Local);
 			Block baseBlock = local.GetBlockLookedAt();
-			Block[] blocks = local.GetSelectedBlocks();
-			if (blocks.Length == 0)
-				blocks = baseBlock.GetConnectedCubes();
+			Block[] blocks = baseBlock.GetConnectedCubes();
 			bool isBaseScaled = !(baseBlock.Scale.x > 0 && baseBlock.Scale.x < 2 && baseBlock.Scale.y > 0 && baseBlock.Scale.y < 2 && baseBlock.Scale.z > 0 && baseBlock.Scale.z < 2);
 			if (isBaseScaled)
 			{

Pixi/Robots/RobotInternetImporter.cs

@@ -27,6 +27,8 @@ namespace Pixi.Robots
         public BlueprintProvider BlueprintProvider { get; }
         
         public static int CubeSize = 3;
+        
+        internal readonly Dictionary<string, FasterList<string>> textBlockInfo = new Dictionary<string, FasterList<string>>();
 
         public RobotInternetImporter()
         {
@@ -124,26 +126,34 @@ namespace Pixi.Robots
 		        blocks[i].position += pos;
 	        }
 	        // set textblock colors (replace <color="white"> with <color=#HEX> in textblocks)
-	        Regex pattern = new Regex("<color=((?:\"white\")|(?:white))>", RegexOptions.Compiled | RegexOptions.Multiline | RegexOptions.IgnoreCase | RegexOptions.CultureInvariant);
+	        Regex pattern = new Regex("<color=(\"white\")|(white)>", RegexOptions.Compiled | RegexOptions.Multiline | RegexOptions.IgnoreCase | RegexOptions.CultureInvariant);
 	        for (int i = 0; i < blocks.Length; i++)
 	        {
 		        if (blocks[i].block == BlockIDs.TextBlock)
 		        {
 			        // TODO this blindly replaces color tags anywhere in metadata, not just ones that will go in the TextBlock's text field
-#if DEBUG
-			        Logging.MetaLog($"Replacing text field in block with colour {blocks[i].color} with #{ColorUtility.ToHtmlStringRGBA(ColorSpaceUtility.UnquantizeToColor(blocks[i].color))}");
-#endif
 			        blocks[i].metadata = pattern.Replace(
 				        blocks[i].metadata,
 				        $"<color=#{ColorUtility.ToHtmlStringRGBA(ColorSpaceUtility.UnquantizeToColor(blocks[i].color))}>");
-			        // NOTE: Regex.Replace replaces the whole match string only when there's a capture group (it's dumb, idk why).
-			        // The non-capturing groups may be messing with .NET or something
 		        }
 	        }
         }
 
         public void PostProcess(string name, ref Block[] blocks)
         {
+	        int textBlockInfoIndex = 0;
+	        for (int c = 0; c < blocks.Length; c++)
+	        {
+		        Block block = blocks[c];
+		        // the goal is for this to never evaluate to true (ie all cubes are translated correctly)
+		        if (block.Type == BlockIDs.TextBlock)
+		        {
+			        textBlockInfoIndex++;
+			        block.Specialise<TextBlock>().Text = textBlockInfo[name][textBlockInfoIndex];
+		        }
+	        }
+
+	        textBlockInfo.Remove(name);
         }
     }
 }